how would you suggest fixing the bug in STCEngine ?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

how would you suggest fixing the bug in STCEngine ?

eishay
Hi,

In the STCEngine.java class there is a line:
// BUG: This check should be bidirectional (see Zamir's paper).
How should you suggest fixing this bug.

Thanks, Eishay
Reply | Threaded
Open this post in threaded view
|

Re: how would you suggest fixing the bug in STCEngine ?

Dawid Weiss-2

As the note states, Oren Zamir's paper has the details of STC implementation...
Now that I look at this, it seems that:

// BUG: This check should be bidirectional (see Zamir's paper).
if (((a_and_b_docCount / b.getNode().getSuffixedDocumentsCount()) > MERGE_THRESHOLD)
&& ((a_and_b_docCount / a_docCount) > MERGE_THRESHOLD))

checking for containment is already bidirectional (with regard to a and b), just
as in the paper... this must have been me being dim for a minute then -- I'll
remove this comment, it makes no sense int he current context.

Dawid

eishay wrote:
> Hi,
>
> In the STCEngine.java class there is a line:
> // BUG: This check should be bidirectional (see Zamir's paper).
> How should you suggest fixing this bug.
>
> Thanks, Eishay

------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today.
Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
Carrot2-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/carrot2-developers
Reply | Threaded
Open this post in threaded view
|

Re: how would you suggest fixing the bug in STCEngine ?

eishay
Thanks, Eishay